Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest.json): change iot_class to calculated #59

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

helto4real
Copy link
Contributor

@helto4real helto4real commented Apr 7, 2024

Proposed change

The iot_class in the manifest.json file has been changed from "cloud_polling" to "calculated". This change is to better reflect the nature of the IoT device's communication method.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionalit)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (make black)
  • Tests have been added to verify that the new code works.

The iot_class in the manifest.json file has been changed from
"cloud_polling" to "Calculated". This change is to better reflect
the nature of the IoT device's communication method.
@helto4real helto4real changed the title feat(manifest.json): change iot_class to Calculated feat(manifest.json): change iot_class to calculated Apr 7, 2024
@helto4real helto4real merged commit b5641bf into main Apr 7, 2024
3 checks passed
@helto4real helto4real deleted the change-iot-class branch April 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant