Fix mouse showing sprite 258 pressing esc #2629
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miguel-hrvs
changed the title
nesbox
reviewed
Jul 13, 2024
nesbox
reviewed
Aug 11, 2024
src/studio/studio.c
Outdated
| @@ -2334,20 +2334,16 @@ static void blitCursor(Studio* studio) | |||
|
|
|||
| tic_point hot = {0}; | |||
|
|
|||
| if(tic->ram->vram.vars.cursor.system) | |||
| bank = &getConfig(studio)->cart->bank0; | |||
There was a problem hiding this comment.
You removed using of vram.vars.cursor.system flag which user could use to switch between system/custom cursors
nesbox
requested changes
Sep 9, 2024
src/studio/studio.c
Outdated
| const tic_palette* pal = &bank->palette.vbank0; | ||
| const tic_tile* tile = &bank->sprites.data[sprite]; | ||
| const tic_tile* tile = &studio->config->cart->bank0.sprites.data[sprite]; |
There was a problem hiding this comment.
you always use the cursor from the config cart, this code will not work if I want to change the cursor from the game
There was a problem hiding this comment.
That's true. I'll look into that.
nesbox
requested changes
Oct 6, 2024
| if(c) | ||
| *dst = tic_rgba(&pal->colors[c]); | ||
| } | ||
| } | ||
| else if(sprite == 0) return; |
There was a problem hiding this comment.
:) we don't draw anything if tic->ram->vram.vars.cursor.system == false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1992 and #2583