Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fee rate in oubound channel to calculate the TLC fee #489

Conversation

contrun
Copy link
Collaborator

@contrun contrun commented Jan 17, 2025

No description provided.

@contrun contrun requested review from quake and chenyukang January 17, 2025 03:22
@contrun contrun changed the title Fix fee calculation with the wrong ChannelUpdate fee rate Use the fee rate in oubound channel to calculate the TLC fee Jan 17, 2025
@contrun contrun force-pushed the fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate branch from 835e61b to d2b5793 Compare January 18, 2025 16:01
@contrun contrun force-pushed the fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate branch from ff24ea1 to 1847ec7 Compare January 18, 2025 16:30
src/fiber/graph.rs Show resolved Hide resolved
src/fiber/network.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.56627% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.47%. Comparing base (8725983) to head (46ac31e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/fiber/channel.rs 87.75% 6 Missing ⚠️
src/fiber/graph.rs 96.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #489      +/-   ##
===========================================
+ Coverage    50.41%   50.47%   +0.05%     
===========================================
  Files           49       49              
  Lines        31824    31858      +34     
===========================================
+ Hits         16045    16080      +35     
+ Misses       15779    15778       -1     
Flag Coverage Δ
unittests 50.47% <91.56%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gpBlockchain
Copy link
Contributor

LGTM

@quake quake merged commit 2f12f40 into nervosnetwork:develop Jan 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants