-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the fee rate in oubound channel to calculate the TLC fee #489
Merged
quake
merged 15 commits into
nervosnetwork:develop
from
contrun:fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate
Jan 22, 2025
Merged
Use the fee rate in oubound channel to calculate the TLC fee #489
quake
merged 15 commits into
nervosnetwork:develop
from
contrun:fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrun
changed the title
Fix fee calculation with the wrong ChannelUpdate fee rate
Use the fee rate in oubound channel to calculate the TLC fee
Jan 17, 2025
contrun
force-pushed
the
fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate
branch
from
January 18, 2025 16:01
835e61b
to
d2b5793
Compare
contrun
force-pushed
the
fix-fee-calculation-with-wrong-ChannelUpdate-fee_rate
branch
from
January 18, 2025 16:30
ff24ea1
to
1847ec7
Compare
quake
reviewed
Jan 21, 2025
chenyukang
reviewed
Jan 21, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #489 +/- ##
===========================================
+ Coverage 50.41% 50.47% +0.05%
===========================================
Files 49 49
Lines 31824 31858 +34
===========================================
+ Hits 16045 16080 +35
+ Misses 15779 15778 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM |
quake
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.