peer-store, wasm: use path as database name in wasm peer-store implementation
#4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Officeyutong
requested review from
zhangsoledad
and removed request for
a team
eval-exec
reviewed
Dec 26, 2024
| let store_name = path.as_ref().to_str().unwrap().to_owned(); | ||
| let store_name_clone = store_name.clone(); | ||
| let database_name = path.as_ref().to_str().unwrap().to_owned(); | ||
| let mut open_request = factory.open(&database_name, Some(1)).unwrap(); |
There was a problem hiding this comment.
There is a secret_key file in network dir. If the secret key in CKB's network directory changes, it may cause the NodeId to change as well. Is this expected? Cc. @driftluo
There was a problem hiding this comment.
No, wasm target‘s secret_key isn't stored on this path. The user manually passes it to ckb
eval-exec
approved these changes
Dec 26, 2024
driftluo
reviewed
Dec 26, 2024
| @@ -67,15 +69,14 @@ pub struct Storage { | |||
| impl Storage { | |||
| pub async fn new<P: AsRef<Path>>(path: P) -> Self { | |||
There was a problem hiding this comment.
The path needs to be added with the network name. No matter what network is passed in, the same path is used now.
By the way，if we use network with DB name， a different path as the object store name， is it ok？(I think the current problem is that the path is the same value regardless of the network.)
There was a problem hiding this comment.
- For the first question, the user can customize store path in network configuration to make different network use different databases
- For the second, IndexedDB limits store creation only to the time of upgrading database, if we want to use different stores for different configurations, we'll need a suitable way to determine database version
driftluo
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the original peer store implementation of wasm , there is only one database (in IndexedDB) to store all peers, different network configurations are distinguished by store names, this can cause one issue: There is no way to use multiple configurations after the database was created, since IndexedDB disallows creating stores unless there is an upgrade for a certain database.
What is changed and how it works?
What's Changed:
This PR updates peer store implementation on wasm, to use database names to distinguish different configurations, and database names comes from
pathsection in network configuration, so makes it possible to switch network configurations in the same website