Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb-metrics: set ckb_chain_tip on startup #4608

Closed
wants to merge 1 commit into from
Closed

ckb-metrics: set ckb_chain_tip on startup #4608

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Set metrics::ckb_chain_tip on startup

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner August 23, 2024 11:08
@eval-exec eval-exec requested review from quake and removed request for a team August 23, 2024 11:08
@chenyukang
Copy link
Collaborator

what is the issue we don't set ckb_chain_tip on startup?
please add more details in the PR description.

@eval-exec eval-exec closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @chenyukang