Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove drop in debug macro #98

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: remove drop in debug macro #98

merged 2 commits into from
Aug 13, 2024

Conversation

quake
Copy link
Member

@quake quake commented Aug 12, 2024 •
edited
Loading

resolve #84

@quake quake requested review from blckngm and XuJiandong August 12, 2024 01:07
@quake quake mentioned this pull request Aug 12, 2024
Closed
blckngm
blckngm approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@blckngm blckngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency you should probably remove let _ = ($(&$args),+); in the cfg[feature = "simulator"] version too.

@quake
Copy link
Member Author

quake commented Aug 13, 2024

For consistency you should probably remove let _ = ($(&$args),+); in the cfg[feature = "simulator"] version too.

resolved

@quake quake merged commit 36942aa into nervosnetwork:master Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@blckngm blckngm blckngm approved these changes

@XuJiandong XuJiandong Awaiting requested review from XuJiandong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable debug_assertions won't ingore function calls in debug!(..) statements.
3 participants
@quake @blckngm @yangby-cryptape