Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fn get_fee_rate_statistics return type #93

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

eval-exec
Copy link
Contributor

@eval-exec eval-exec commented Oct 19, 2023

Ref: https://github.com/nervosnetwork/ckb/blob/cff0cabc02b7d841053f818330a5e9d07c863130/rpc/src/module/chain.rs#L1605-L1607

The first argument of get_fee_rate_statistics should be target, and its return type should be an Option

@quake Request for review, and we need to publish a new cargo release.

@gpBlockchain gpBlockchain mentioned this pull request Oct 25, 2023
@quake quake merged commit f296e77 into nervosnetwork:master Oct 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants