fix: override the original witnesses when sign transactions #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I'm working on a new type script, which requires its own witness.
But when I build a transaction with
ckb_sdk::XxxUnlocker
, the witness will be overridden.When sign transactions, the method to handle witnesses are correct.
ckb-sdk-rust/src/unlock/signer.rs
Lines 109 to 119 in c45c4dc
But, when call the following code to prepare for sign transactions:
ckb-sdk-rust/src/transaction/builder/mod.rs
Line 182 in c45c4dc
The original witnesses will be overridden.
I tested this patch with my project, it works!