Apply cargo-clippy fix

nervosnetwork · Sep 18, 2024 · 0496458 · 0496458
1 parent 5056495
commit 0496458
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 14 deletions.
diff --git a/src/tests/omni_lock.rs b/src/tests/omni_lock.rs
@@ -215,7 +215,7 @@ fn test_omnilock_simple_hash_rc_input(mut cfg: OmniLockConfig) {
     cfg.set_admin_config(admin_config);
 
     let sender = build_omnilock_script(&cfg);
-    for (lock, capacity_opt) in vec![(sender.clone(), Some(100 * ONE_CKB))] {
+    for (lock, capacity_opt) in [(sender.clone(), Some(100 * ONE_CKB))] {
         ctx.add_simple_live_cell(random_out_point(), lock, capacity_opt);
     }
 
@@ -407,7 +407,7 @@ fn test_omnilock_simple_hash_rc(mut cfg: OmniLockConfig, unlock_mode: OmniUnlock
         OmniUnlockMode::Normal => (None, 0),
     };
     let sender = build_omnilock_script(&cfg);
-    for (lock, capacity_opt) in vec![(sender.clone(), Some(300 * ONE_CKB))] {
+    for (lock, capacity_opt) in [(sender.clone(), Some(300 * ONE_CKB))] {
         ctx.add_simple_live_cell(random_out_point(), lock, capacity_opt);
     }
 
@@ -517,7 +517,7 @@ fn test_omnilock_simple_hash_rc2(mut cfg: OmniLockConfig) {
     cfg.set_admin_config(admin_config);
 
     let sender = build_omnilock_script(&cfg);
-    for (lock, capacity_opt) in vec![(sender.clone(), Some(300 * ONE_CKB))] {
+    for (lock, capacity_opt) in [(sender.clone(), Some(300 * ONE_CKB))] {
         ctx.add_simple_live_cell(random_out_point(), lock, capacity_opt);
     }
 
@@ -686,7 +686,7 @@ fn test_omnilock_transfer_from_multisig_wl_commnon(unlock_mode: OmniUnlockMode)
         false,
     ));
     let sender = build_omnilock_script(&cfg);
-    for (lock, capacity_opt) in vec![
+    for (lock, capacity_opt) in [
         (sender.clone(), Some(100 * ONE_CKB)),
         (sender.clone(), Some(200 * ONE_CKB)),
         (sender.clone(), Some(300 * ONE_CKB)),
@@ -874,7 +874,7 @@ fn test_omnilock_transfer_from_ownerlock_wl_admin() {
         false,
     ));
     let sender0 = build_omnilock_script(&cfg);
-    for (lock, capacity_opt) in vec![(sender0.clone(), Some(50 * ONE_CKB))] {
+    for (lock, capacity_opt) in [(sender0.clone(), Some(50 * ONE_CKB))] {
         ctx.add_simple_live_cell(random_out_point(), lock, capacity_opt);
     }
 

diff --git a/src/tests/omni_lock_util.rs b/src/tests/omni_lock_util.rs
@@ -72,7 +72,7 @@ fn build_script(
             always_success.as_builder().args(hash.pack()).build()
         } else {
             // this args can be anything
-            let args = vec![0u8; 32];
+            let args: &[u8] = &[0u8; 32];
             Script::new_builder()
                 .args(args.pack())
                 .code_hash(hash.pack())

diff --git a/src/traits/default_impls.rs b/src/traits/default_impls.rs
@@ -79,7 +79,7 @@ impl DefaultCellDepResolver {
             .map(|(tx_index, tx)| {
                 tx.outputs()
                     .into_iter()
-                    .zip(tx.outputs_data().into_iter())
+                    .zip(tx.outputs_data())
                     .enumerate()
                     .map(|(index, (output, data))| {
                         if tx_index == SIGHASH_OUTPUT_LOC.0 && index == SIGHASH_OUTPUT_LOC.1 {

diff --git a/src/tx_builder/dao.rs b/src/tx_builder/dao.rs
@@ -358,12 +358,7 @@ impl TxBuilder for DaoWithdrawBuilder {
             inputs.push(input);
             witnesses.push(witness.pack());
         }
-        header_deps.extend(
-            prepare_block_hashes
-                .into_iter()
-                .collect::<HashSet<_>>()
-                .into_iter(),
-        );
+        header_deps.extend(prepare_block_hashes.into_iter().collect::<HashSet<_>>());
 
         let (outputs, outputs_data) = match &self.receiver {
             DaoWithdrawReceiver::LockScript { script, fee_rate } => {

diff --git a/src/types/script_id.rs b/src/types/script_id.rs
@@ -40,7 +40,7 @@ impl ScriptId {
         Script::new_builder()
             .code_hash(self.code_hash.pack())
             .hash_type(self.hash_type.into())
-            .args(vec![0u8; 32].pack())
+            .args(<[u8]>::pack(&[0u8; 32]))
             .build()
     }
 }