Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add perun types && fix: add marshal method for script group #225

Open
wants to merge 11 commits into
base: v2
Choose a base branch
from
Open

feat: add perun types && fix: add marshal method for script group #225

wants to merge 11 commits into from

Conversation

ravi0131
Copy link

@ravi0131 ravi0131 commented Oct 17, 2024 •
edited
Loading

What does this PR do?

  • Add support for Perun types for perun-ckb-backend (feat)
  • add method for marshalling TransactionScriptWithGroups (fix)

@ravi0131 ravi0131 changed the title feat: add perun types feat: add perun types Oct 17, 2024
@ravi0131 ravi0131 changed the title feat: add perun types feat: add perun types Oct 17, 2024
@ravi0131 ravi0131 changed the title feat: add perun types feat: add perun types && fix: add marshal method for script group Oct 17, 2024
eval-exec
eval-exec reviewed Nov 28, 2024
View reviewed changes
types/molecule/offchain_type.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was supposed to be generated.
Also do keep the generator header when committing generated codes
It should contains something like:

// Generated by Molecule 0.7.3
// Generated by Moleculec-Go 0.1.10

in the head of the generated file in order to reproduce the source. also the original xxx.mol file should also be contained @ravi0131

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. As @code-monad mentioned, it is generated.

code-monad
code-monad requested changes Dec 5, 2024
View reviewed changes
types/molecule/offchain_type.go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was supposed to be generated.
Also do keep the generator header when committing generated codes
It should contains something like:

// Generated by Molecule 0.7.3
// Generated by Moleculec-Go 0.1.10

in the head of the generated file in order to reproduce the source. also the original xxx.mol file should also be contained @ravi0131

@ravi0131
Copy link
Author

ravi0131 commented Dec 5, 2024

Alright. Thanks for the feedback @code-monad, I will add the header for offchain_type.go and since perun_types.go is generated, I will add its corresponding molecule file too.

@ravi0131
nervosnetwork#225: add .mol files and headers
2d8fee8 
- molecule schema of perun and offchain types
- headers in offchain_type.go
@ravi0131
Copy link
Author

ravi0131 commented Dec 16, 2024 •
edited
Loading

@code-monad @eval-exec I have added the header and the molecule schemas

eval-exec
eval-exec approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, invite @code-monad @quake to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@code-monad code-monad Awaiting requested review from code-monad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ravi0131 @code-monad @eval-exec @janbormet @NhoxxKienn