Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contract attrs may exist same deployed_cell_output_id but different role #2338

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz December 13, 2024 01:50
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 152 lines in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (fb7293a) to head (2b86ff6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rs/analyze_contract_from_cell_dependency_worker.rb 0.00% 109 Missing ⚠️
...s/migration/analyze_contract_from_start_block.rake 0.00% 43 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2338      +/-   ##
===========================================
- Coverage    56.99%   56.68%   -0.31%     
===========================================
  Files          366      366              
  Lines        10475    10531      +56     
===========================================
  Hits          5970     5970              
- Misses        4505     4561      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Dec 13, 2024
Merged via the queue into nervosnetwork:develop with commit 72835d1 Dec 13, 2024
1 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the issue-794-7 branch December 13, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants