Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: daily_stattistic generator condition #2288

Merged

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz November 18, 2024 09:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (f373f6b) to head (3d135d5).
Report is 538 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (3d135d5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (3d135d5)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2288      +/-   ##
===========================================
- Coverage    67.56%   60.04%   -7.52%     
===========================================
  Files          289      354      +65     
  Lines         7944    10108    +2164     
===========================================
+ Hits          5367     6069     +702     
- Misses        2577     4039    +1462     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Nov 18, 2024
Merged via the queue into nervosnetwork:develop with commit 1898918 Nov 18, 2024
2 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the fix-daily-statistic-condition branch November 18, 2024 10:14
zmcNotafraid added a commit that referenced this pull request Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2024
Revert "fix: daily_stattistic generator condition (#2288)"

This reverts commit 1898918.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants