Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance dead cell_outputs count query #2213

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.21%. Comparing base (f373f6b) to head (5d9437e).
Report is 508 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/cell_output.rb 25.00% 3 Missing ⚠️
app/services/charts/block_statistic_generator.rb 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (5d9437e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (5d9437e)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
- Coverage    67.56%   60.21%   -7.35%     
===========================================
  Files          289      355      +66     
  Lines         7944    10172    +2228     
===========================================
+ Hits          5367     6125     +758     
- Misses        2577     4047    +1470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Oct 8, 2024
Merged via the queue into nervosnetwork:develop with commit 6d8cc5e Oct 8, 2024
1 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the calculate-dead-celloutpus-count branch October 8, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants