Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bitcoin transaction detect worker #1701

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Mar 26, 2024

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid March 26, 2024 04:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 65.64%. Comparing base (f373f6b) to head (9f942c4).
Report is 108 commits behind head on develop.

❗ Current head 9f942c4 differs from pull request most recent head 9171b2f. Consider uploading reports for the commit 9171b2f to get more accurate results

Files Patch % Lines
app/workers/bitcoin_transaction_detect_worker.rb 4.54% 21 Missing ⚠️
app/utils/ckb_utils.rb 28.57% 5 Missing ⚠️
app/models/concerns/ckb_transactions/bitcoin.rb 0.00% 4 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 0.00% 2 Missing ⚠️
app/controllers/concerns/cell_data_comparator.rb 33.33% 2 Missing ⚠️
app/models/ckb_sync/api.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1701      +/-   ##
===========================================
- Coverage    67.56%   65.64%   -1.92%     
===========================================
  Files          289      329      +40     
  Lines         7944     8858     +914     
===========================================
+ Hits          5367     5815     +448     
- Misses        2577     3043     +466     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Mar 26, 2024
Merged via the queue into nervosnetwork:develop with commit b4f7fa8 Mar 26, 2024
1 check passed
@rabbitz rabbitz deleted the feat/rgb branch March 26, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants