Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sentry transaction performance tracer #1641

Conversation

zmcNotafraid
Copy link
Collaborator

@zmcNotafraid zmcNotafraid commented Feb 22, 2024

There were too many sentry transaction logs sent.And we only use new relic to watch performance.

@zmcNotafraid zmcNotafraid requested a review from rabbitz February 22, 2024 08:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f373f6b) 67.56% compared to head (8b032f7) 66.23%.
Report is 35 commits behind head on develop.

❗ Current head 8b032f7 differs from pull request most recent head b1730d3. Consider uploading reports for the commit b1730d3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1641      +/-   ##
===========================================
- Coverage    67.56%   66.23%   -1.33%     
===========================================
  Files          289      310      +21     
  Lines         7944     8492     +548     
===========================================
+ Hits          5367     5625     +258     
- Misses        2577     2867     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Feb 22, 2024
Merged via the queue into nervosnetwork:develop with commit 780f081 Feb 22, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the remove-sentry-transaction-tracer branch February 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants