Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 508 8 #1566

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Issue 508 8 #1566

merged 3 commits into from
Jan 15, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz January 15, 2024 03:33
@codecov-commenter
Copy link

Codecov Report

Attention: 212 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (89c73a0) 67.48%.
Report is 195 commits behind head on develop.

❗ Current head 89c73a0 differs from pull request most recent head 1846676. Consider uploading reports for the commit 1846676 to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 67.56% 24 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 83.89% 24 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
...p/serializers/omiga_inscription_info_serializer.rb 0.00% 14 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/utils/ckb_utils.rb 87.34% 10 Missing ⚠️
...ontrollers/api/v1/omiga_inscriptions_controller.rb 80.55% 7 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1566      +/-   ##
===========================================
+ Coverage    66.37%   67.48%   +1.10%     
===========================================
  Files          275      289      +14     
  Lines         7397     7922     +525     
===========================================
+ Hits          4910     5346     +436     
- Misses        2487     2576      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 15, 2024
Merged via the queue into nervosnetwork:develop with commit eecb50f Jan 15, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-508-8 branch January 15, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants