Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return integer for create_timestamp time extraction #1538

Merged

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Dec 21, 2023

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid December 21, 2023 00:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 249 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (fedbf84) 67.12%.
Report is 162 commits behind head on develop.

❗ Current head fedbf84 differs from pull request most recent head a77bb1b. Consider uploading reports for the commit a77bb1b to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
...ib/tasks/migration/update_output_cells_status.rake 29.26% 29 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 19.23% 21 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
...ib/tasks/migration/async_missing_transactions.rake 15.78% 16 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
lib/scheduler.rb 0.00% 12 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
+ Coverage    66.37%   67.12%   +0.74%     
===========================================
  Files          275      285      +10     
  Lines         7397     7736     +339     
===========================================
+ Hits          4910     5193     +283     
- Misses        2487     2543      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz
Copy link
Collaborator Author

rabbitz commented Dec 21, 2023

When searching for a transaction to match an input cell with its corresponding output cell, two foreign keys can be utilized: previous_cell_output_id and consumed_by_id. The consumed_by_id is only present in transactions that have been committed.

@rabbitz rabbitz added this pull request to the merge queue Dec 21, 2023
Merged via the queue into nervosnetwork:develop with commit 8864b57 Dec 21, 2023
1 check passed
@rabbitz rabbitz deleted the feat/address_pending_transactions branch December 21, 2023 04:55
tianlitao pushed a commit to tianlitao/ckb-explorer that referenced this pull request Feb 19, 2024
…rk#1538)

* fix: return integer for create_timestamp time extraction

* fix: pending transaction income
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants