Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize transaction display cells cache key #1536

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Dec 19, 2023

Because the redis configuration of node processor is different from the configuration of explorer api, only the cache key can be adjusted here.

@codecov-commenter
Copy link

Codecov Report

Attention: 249 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (1b263c4) 67.09%.
Report is 160 commits behind head on develop.

❗ Current head 1b263c4 differs from pull request most recent head b6f8811. Consider uploading reports for the commit b6f8811 to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
...ib/tasks/migration/update_output_cells_status.rake 29.26% 29 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 19.23% 21 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
...ib/tasks/migration/async_missing_transactions.rake 15.78% 16 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
lib/scheduler.rb 0.00% 12 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1536      +/-   ##
===========================================
+ Coverage    66.37%   67.09%   +0.71%     
===========================================
  Files          275      285      +10     
  Lines         7397     7728     +331     
===========================================
+ Hits          4910     5185     +275     
- Misses        2487     2543      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Dec 19, 2023
Merged via the queue into nervosnetwork:develop with commit 3b88a44 Dec 19, 2023
1 check passed
@rabbitz rabbitz deleted the fix/display_cells_cache branch December 19, 2023 05:50
tianlitao pushed a commit to tianlitao/ckb-explorer that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants