Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type id search using typescript args #1533

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Dec 13, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (bf3c652) 67.51%.
Report is 157 commits behind head on develop.

❗ Current head bf3c652 differs from pull request most recent head 0f2d073. Consider uploading reports for the commit 0f2d073 to get more accurate results

Files Patch % Lines
...ib/tasks/migration/update_output_cells_status.rake 29.26% 29 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 19.23% 21 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
...ib/tasks/migration/async_missing_transactions.rake 15.78% 16 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
lib/websocket.rb 0.00% 10 Missing ⚠️
lib/scheduler.rb 0.00% 7 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1533      +/-   ##
===========================================
+ Coverage    66.37%   67.51%   +1.13%     
===========================================
  Files          275      284       +9     
  Lines         7397     7674     +277     
===========================================
+ Hits          4910     5181     +271     
- Misses        2487     2493       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz force-pushed the feat/search_by_type_id branch from 94ef94f to 4dd5458 Compare December 14, 2023 00:24
@rabbitz rabbitz force-pushed the feat/search_by_type_id branch from 4dd5458 to 358e47d Compare December 14, 2023 00:33
@rabbitz rabbitz added this pull request to the merge queue Dec 14, 2023
Merged via the queue into nervosnetwork:develop with commit 8e1d98e Dec 14, 2023
1 check passed
@rabbitz rabbitz deleted the feat/search_by_type_id branch December 14, 2023 01:56
tianlitao pushed a commit to tianlitao/ckb-explorer that referenced this pull request Feb 19, 2024
* fix: type id search using typescript args

* chore: adjust tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants