Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict with testnet #1511

Merged

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid changed the base branch from develop to master November 20, 2023 09:04
@codecov-commenter
Copy link

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (0b4da62) 66.95% compared to head (0d05b24) 67.30%.
Report is 35 commits behind head on master.

❗ Current head 0d05b24 differs from pull request most recent head 30ae902. Consider uploading reports for the commit 30ae902 to get more accurate results

Files Patch % Lines
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 11.76% 15 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 5 Missing ⚠️
.../controllers/api/v2/ckb_transactions_controller.rb 60.00% 2 Missing ⚠️
lib/scheduler.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
+ Coverage   66.95%   67.30%   +0.35%     
==========================================
  Files         282      283       +1     
  Lines        7608     7635      +27     
==========================================
+ Hits         5094     5139      +45     
+ Misses       2514     2496      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid requested a review from rabbitz November 20, 2023 09:47
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Nov 20, 2023
Merged via the queue into nervosnetwork:master with commit f7a912f Nov 20, 2023
1 check passed
@zmcNotafraid zmcNotafraid deleted the fix-conflict-with-testnet branch November 20, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants