Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 446 #1474

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Issue 446 #1474

merged 2 commits into from
Oct 19, 2023

Conversation

zmcNotafraid
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (02a8c07) 66.86%.
Report is 123 commits behind head on develop.

❗ Current head 02a8c07 differs from pull request most recent head 5948c40. Consider uploading reports for the commit 5948c40 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1474      +/-   ##
===========================================
+ Coverage    66.37%   66.86%   +0.48%     
===========================================
  Files          275      282       +7     
  Lines         7397     7624     +227     
===========================================
+ Hits          4910     5098     +188     
- Misses        2487     2526      +39     
Files Coverage Δ
...trollers/api/v1/address_transactions_controller.rb 95.55% <100.00%> (-0.10%) ⬇️
app/controllers/api/v1/blocks_controller.rb 95.34% <ø> (-0.11%) ⬇️
...rollers/api/v1/contract_transactions_controller.rb 100.00% <100.00%> (ø)
.../controllers/api/v1/udt_transactions_controller.rb 100.00% <100.00%> (ø)
...controllers/api/v1/udt_verifications_controller.rb 100.00% <100.00%> (ø)
app/controllers/api/v1/udts_controller.rb 100.00% <100.00%> (ø)
...trollers/api/v2/pending_transactions_controller.rb 100.00% <100.00%> (ø)
app/controllers/api/v2/transactions_controller.rb 100.00% <100.00%> (ø)
app/models/cell_input.rb 61.36% <ø> (ø)
app/models/cell_output.rb 73.42% <100.00%> (-0.52%) ⬇️
... and 35 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Oct 19, 2023
Merged via the queue into nervosnetwork:develop with commit 5cefdc6 Oct 19, 2023
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-446 branch October 19, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants