Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter committed address transactions #1466

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Oct 8, 2023

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid October 8, 2023 09:05
@codecov-commenter
Copy link

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (f83310c) 66.96%.
Report is 72 commits behind head on develop.

❗ Current head f83310c differs from pull request most recent head 31a8240. Consider uploading reports for the commit 31a8240 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1466      +/-   ##
===========================================
+ Coverage    66.37%   66.96%   +0.59%     
===========================================
  Files          275      282       +7     
  Lines         7397     7608     +211     
===========================================
+ Hits          4910     5095     +185     
- Misses        2487     2513      +26     
Files Coverage Δ
...trollers/api/v1/address_transactions_controller.rb 95.55% <100.00%> (-0.10%) ⬇️
app/controllers/api/v1/blocks_controller.rb 95.34% <ø> (-0.11%) ⬇️
...rollers/api/v1/contract_transactions_controller.rb 100.00% <100.00%> (ø)
.../controllers/api/v1/udt_transactions_controller.rb 100.00% <100.00%> (ø)
...controllers/api/v1/udt_verifications_controller.rb 100.00% <100.00%> (ø)
app/controllers/api/v1/udts_controller.rb 100.00% <100.00%> (ø)
...trollers/api/v2/pending_transactions_controller.rb 100.00% <100.00%> (ø)
app/controllers/api/v2/transactions_controller.rb 100.00% <100.00%> (ø)
app/models/cell_input.rb 61.36% <ø> (ø)
app/models/cell_output.rb 73.42% <100.00%> (-0.52%) ⬇️
... and 32 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Oct 8, 2023
Merged via the queue into nervosnetwork:develop with commit 755a05c Oct 8, 2023
1 check passed
@rabbitz rabbitz deleted the fix/address_transactions branch October 8, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants