feat: hide script item from list if its deployment info is not set (#140

) * feat: hide script item from list if its deployment info is not set * refactor: remove useless ternary
nervosnetwork · Nov 9, 2023 · 01495d0 · 01495d0
1 parent 984c024
commit 01495d0
Showing 1 changed file with 16 additions and 19 deletions.
diff --git a/src/pages/ScriptList/index.tsx b/src/pages/ScriptList/index.tsx
@@ -210,6 +210,7 @@ const ScriptList: FC = () => {
       <div className={styles.container}>
         {[...scripts].map(([label, meta]) => {
           const script = scriptDataList.find(s => s.tag === label)
+          if (!script) return null
           return (
             <details key={label} id={label} open={label === defaultOpenLabel}>
               <summary data-deprecated={!!meta.deprecated} title={meta.deprecated ? 'Deprecated' : undefined}>
@@ -226,22 +227,19 @@ const ScriptList: FC = () => {
                       </a>
                     ) : null,
                   )}
-                  {script ? (
-                    <a
-                      href={`/script/${script.codeHashes[0]}/${script.hashType}`}
-                      target="_blank"
-                      rel="noopener noreferrer"
-                    >
-                      {t('script_list.link.detail')}
-                    </a>
-                  ) : null}
+                  <a
+                    href={`/script/${script.codeHashes[0]}/${script.hashType}`}
+                    target="_blank"
+                    rel="noopener noreferrer"
+                  >
+                    {t('script_list.link.detail')}
+                  </a>
                 </div>
-                {script ? (
-                  <>
-                    <h3>{`${t(`script_list.on_chain_data`)}:`}</h3>
-                    {script.codeHashes.map((codeHash: string, idx: number) => (
-                      <pre key={codeHash}>
-                        {`{
+                <>
+                  <h3>{`${t(`script_list.on_chain_data`)}:`}</h3>
+                  {script.codeHashes.map((codeHash: string, idx: number) => (
+                    <pre key={codeHash}>
+                      {`{
   "code_hash": "${codeHash}",
   "hash_type": "${script.hashType}",
   "out_point": {
@@ -250,10 +248,9 @@ const ScriptList: FC = () => {
   },
   "dep_type": "${script.depType}"
 }`}
-                      </pre>
-                    ))}
-                  </>
-                ) : null}
+                    </pre>
+                  ))}
+                </>
               </div>
             </details>
           )