Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: "onDragLeave is not working" (#719) #720

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rreddyNg
Copy link

Fixes Issue #719

@nervgh nervgh added the bug label Mar 27, 2017
@yhnavein
Copy link

yhnavein commented Oct 4, 2017

Any plans to merge it soon?
We are looking forward to have this PR integrated. Really.

@theoomoregbee theoomoregbee requested a review from nervgh October 4, 2017 20:50
@nervgh
Copy link
Owner

nervgh commented Oct 7, 2017

This is quite similar with #643. @yhnavein Have you tested it? Does it works?

@yhnavein
Copy link

yhnavein commented Oct 7, 2017 via email

@Stalinko
Copy link

Stalinko commented Jan 8, 2018

This solution is overcomplicated and doesn't fully fix the problem. Cancelling of the timeout must be added into onDragOver as well, otherwise flickering effect keeps appearing, just rarer.

That fix is much more clear and fully solves the issue: #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants