Move the Shoehorn release script ordering to core #949
+253
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been the default for such a long time, it seems like it's time. The other reason for doing this is that Shoehorn's other features are not nearly as well used and they're starting to need updates especially with the Erlang and Elixir logging changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR.
This moves over the Shoehorn release script functionality every Nerves project uses and there are even assumptions baked into projects about OTP applications starting up as temporary rather than permanent. Unit tests still need to be moved over, documentation updated, and configuration option names probably need updating.
With this PR, I wanted to start the conversation on removing the
:shoehorndependency from Nerves projects. Users could add it back for the application restart feature if they needed it, but the code would no longer come along by default. At a minimum, the application restart code needs to be updated since it uses the deprecated error_logger. There are arguments that there are better ways of handling the problems that it was written to fix, so separating it from the code that gets used a lot seems helpful.