Create audit log when archive is sent to device

[nshoes]

If an archive is sent to a device on connect or from an archive update, an audit log is created specifying device, deployment, and archive details.

[joshk]

can you please return :ok from the templates, this makes dialyzer happy

[jjcarstens]

I don't think we want this. There is no discernment check for archive versions and this happens on every connection, so this has potential to really bloat the logs again (like online/offline/exetension logs that have been removed)

Perhaps a small metric is useful or we wait until proper adjustment and handling of archives?

[joshk]

I don't think we want this. There is no discernment check for archive versions and this happens on every connection, so this has potential to really bloat the logs again (like online/offline/exetension logs that have been removed)

Perhaps a small metric is useful or we wait until proper adjustment and handling of archives?

Ahhh, true true, there is no annoucement from the device about what archive version has been downloaded and installed (something bigger we should consider improving)

what about moving the logging to handle_info(%Broadcast{event: "archives/updated"}, socket), as this will only be logged when a device is already connected?

[nshoes]

so this has potential to really bloat the logs again (like online/offline/exetension logs that have been removed)

Great callout, thank you.

what about moving the logging to handle_info(%Broadcast{event: "archives/updated"}, socket), as this will only be logged when a device is already connected?

This is a good option to avoid table bloat over time, but then we don't get an audit log if we do send the archive update on connect (which feels weird). I think if we log 2 out of 3 scenarios that's better than none?

[esvinson]

Do we need to store it in the database or can we just log it with the normal logger?

[esvinson]

Perhaps a small metric is useful or we wait until proper adjustment and handling of archives?

We'd want to avoid anything metric related that's hub device specific for cost reasons. Deployment specific might be ok.

[joshk]

I would suggest only adding this audit log event to handle_info(%Broadcast{event: "archives/updated"}, socket) as it would only occur when the deployment archive is updated and sent to connected devices. It would help devs and support know if an online device received the archive.

[nshoes]

@joshk it shall be done