Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ns-process-data bug with dev version of colmap #2651

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Ns-process-data bug with dev version of colmap #2651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b3960d
only parse digit and decimal
AdamRashid96 Dec 7, 2023
1435512
formatting
AdamRashid96 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nerfstudio/process_data/colmap_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def get_colmap_version(colmap_cmd: str, default_version=3.8) -> float:
assert output is not None
for line in output.split("\n"):
if line.startswith("COLMAP"):
return float(line.split(" ")[1])
version = line.split(" ")[1]
version = "".join([c for c in version if c.isdigit() or c == "."])
return float(version)
CONSOLE.print(f"[bold red]Could not find COLMAP version. Using default {default_version}")
return default_version

Expand Down
Loading