adds prow job to install nephio components on kubeadm cluster #297

vjayaramrh · 2024-08-19T15:32:51Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This PR adds prow job support to deploy Nephio management components on a kubeadm cluster. The files to review as part of this PR are

  .prow.yaml
   e2e/provision/init.sh
   e2e/provision/install_sandbox.sh
   e2e/provision/playbooks/deploy_kubeadm_k8s.yml
   e2e/terraform/main.tf
   e2e/terraform/modules/gcp/main.tf
   e2e/terraform/modules/gcp/variables.tf

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Please review and merge #296 prior to merging this PR. This PR includes files from the #296 PR

Does this PR introduce a user-facing change?:

NONE

vjayaramrh · 2024-08-19T17:08:53Z

/test e2e-kubeadm-fedora-34

vjayaramrh · 2024-08-19T21:40:19Z

/test e2e-kubeadm-ubuntu-jammy

vjayaramrh · 2024-08-20T09:51:49Z

/test e2e-kubeadm-ubuntu-jammy

vjayaramrh · 2024-08-20T09:52:14Z

/test e2e-kubeadm-fedora-34

vjayaramrh · 2024-08-20T14:19:14Z

/test e2e-kubeadm-ubuntu-jammy

vjayaramrh · 2024-08-20T14:58:08Z

/test e2e-kubeadm-ubuntu-jammy

arora-sagar · 2024-08-20T15:44:00Z

@vjayaramrh Didn't we decide to bump the fedora version to 40 instead of 34 after R3?

vjayaramrh · 2024-08-20T15:47:28Z

@vjayaramrh Didn't we decide to bump the fedora version to 40 instead of 34 after R3?

Good point, we could atleast for the kubeadm cluster deployment as a first step.

vjayaramrh · 2024-08-20T16:27:57Z

/test e2e-kubeadm-ubuntu-jammy

nephio-prow · 2024-08-20T16:28:08Z

@vjayaramrh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test presubmit-test-infra-inrepoconfig-validation

Use /test all to run all jobs.

In response to this:

/test e2e-kubeadm-ubuntu-jammy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

…ocations Co-authored-by: Vishwanath Jayaraman <[email protected]>

Co-authored-by: Daniel Kostecki <[email protected]>

…ephio-project#46) (nephio-project#296) * add support for installing nonKIND cluster via kubeadm allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases * Add support for installing nonKIND cluster via kubeadm, moving file locations Co-authored-by: Vishwanath Jayaraman <[email protected]> * Change yml file suffix in main --------- Co-authored-by: vjayaramrh <[email protected]>

vjayaramrh · 2024-08-20T22:21:04Z

/test e2e-kubeadm-ubuntu-jammy

vjayaramrh · 2024-08-21T02:17:16Z

/test e2e-kubeadm-fedora-38

nephio-prow · 2024-08-21T06:33:37Z

@vjayaramrh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
e2e-kubeadm-fedora-40	`3ea8634`	link	false	`/test e2e-kubeadm-fedora-40`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Co-authored-by: Daniel Kostecki <[email protected]>

efiacor · 2024-08-21T17:27:16Z

.prow.yaml

+  - name: e2e-kubeadm-ubuntu-jammy
+    annotations:
+    labels:
+    run_if_changed: '^e2e/'


Should we refine these. I feel it's overkill running all of these jobs every time there is a change made anywhere in the e2e dir

I am up for any suggestions, (As a side note, this job is optional for PR merge at the moment)
CC: @radoslawc

@efiacor @vjayaramrh that's my feeling as well, this however would require modularising each job as they are now defined in single place. I've created issue for that: nephio-project/sig-release#47

Okay lets merge this PR and take the other issue in another PR.

efiacor · 2024-08-21T17:27:30Z

.prow.yaml

+  - name: e2e-kubeadm-fedora-38
+    annotations:
+    labels:
+    run_if_changed: '^e2e/'


efiacor · 2024-08-21T17:36:05Z

e2e/provision/init.sh

 HOME=${NEPHIO_HOME:-/home/$NEPHIO_USER}
 REPO_DIR=${NEPHIO_REPO_DIR:-$HOME/test-infra}
 DOCKERHUB_USERNAME=${DOCKERHUB_USERNAME:-""}
 DOCKERHUB_TOKEN=${DOCKERHUB_TOKEN:-""}
 FAIL_FAST=${FAIL_FAST:-$(get_metadata fail_fast "false")}
+# MGMT_CLUSTER_TYPE is intended to be set by prow jobs


Is this the case? Where is it set?

I tagged you and added a comment in .prow.yml file where this is set

efiacor · 2024-08-21T17:37:41Z

e2e/provision/install_sandbox.sh

@@ -75,6 +75,14 @@ fact_caching_connection = /tmp
 EOT

 # Management cluster creation
+if [[ ${MGMT_CLUSTER_TYPE:-kind} == "kubeadm" ]]; then


Silly question but do we get multiple mgmt clusters if this executes?

If Google GKE or REd Hat decides to add their clusters to CI/CD, then we could get different types. For now it will just be kind and kubeadm.

vjayaramrh · 2024-08-21T18:03:32Z

.prow.yaml

+            - "-c"
+            - |
+              set -eE; cd "$(git rev-parse --show-toplevel)/e2e/terraform"; trap 'terraform destroy -target module.gcp-ubuntu-jammy -auto-approve' EXIT;
+              terraform init && timeout 120m terraform apply -target module.gcp-ubuntu-jammy -var="fail_fast=true" -var="mgmt_cluster_type=kubeadm" -auto-approve


@efiacor FYI The prow job sets the management cluster type here

radoslawc · 2024-08-22T11:49:51Z

/approve

nephio-prow · 2024-08-22T11:49:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [radoslawc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arora-sagar · 2024-08-22T14:20:58Z

/lgtm

nephio-prow bot added the kind/feature label Aug 19, 2024

nephio-prow bot requested review from arora-sagar and liamfallon August 19, 2024 15:32

vjayaramrh requested review from radoslawc and efiacor August 19, 2024 15:33

vjayaramrh force-pushed the ci_kubeadm branch 2 times, most recently from 0ea00b7 to 0c37574 Compare August 19, 2024 20:19

vjayaramrh force-pushed the ci_kubeadm branch from 0c37574 to ccb46d1 Compare August 20, 2024 03:13

vjayaramrh force-pushed the ci_kubeadm branch from ccb46d1 to 82843c1 Compare August 20, 2024 15:41

vjayaramrh force-pushed the ci_kubeadm branch 3 times, most recently from e2e6bf3 to 6a614e7 Compare August 20, 2024 16:07

vjayaramrh force-pushed the ci_kubeadm branch from 6a614e7 to 4f9d81c Compare August 20, 2024 16:42

vjayaramrh and others added 4 commits August 20, 2024 11:55

add support for installing nonKIND cluster via kubeadm

1e19096

allows for installing nonKIND K8S cluster on ubuntu and fedora for e2e test cases

Add support for installing nonKIND cluster via kubeadm, moving file l…

a42dd09

…ocations Co-authored-by: Vishwanath Jayaraman <[email protected]>

adds prow job to install Nephio components on kubeadm cluster

42d42f8

Co-authored-by: Daniel Kostecki <[email protected]>

vjayaramrh force-pushed the ci_kubeadm branch 2 times, most recently from 3ea8634 to 76dbd84 Compare August 20, 2024 19:39

vjayaramrh force-pushed the ci_kubeadm branch from 76dbd84 to 7a9d4c1 Compare August 21, 2024 04:38

adds prow job to install nephio components on kubeadm cluster

1c20836

Co-authored-by: Daniel Kostecki <[email protected]>

vjayaramrh force-pushed the ci_kubeadm branch from 7a9d4c1 to 1c20836 Compare August 21, 2024 13:22

efiacor reviewed Aug 21, 2024

View reviewed changes

vjayaramrh commented Aug 21, 2024

View reviewed changes

nephio-prow bot added the approved label Aug 22, 2024

nephio-prow bot assigned arora-sagar Aug 22, 2024

nephio-prow bot added the lgtm label Aug 22, 2024

nephio-prow bot merged commit f90ff7b into nephio-project:main Aug 22, 2024
9 of 10 checks passed

vjayaramrh deleted the ci_kubeadm branch December 9, 2024 12:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds prow job to install nephio components on kubeadm cluster #297

adds prow job to install nephio components on kubeadm cluster #297

vjayaramrh commented Aug 19, 2024 •

edited

Loading

vjayaramrh commented Aug 19, 2024

vjayaramrh commented Aug 19, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

arora-sagar commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024 •

edited

Loading

vjayaramrh commented Aug 20, 2024

nephio-prow bot commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 21, 2024

nephio-prow bot commented Aug 21, 2024 •

edited

Loading

efiacor Aug 21, 2024

vjayaramrh Aug 21, 2024 •

edited

Loading

radoslawc Aug 22, 2024

arora-sagar Aug 22, 2024

efiacor Aug 21, 2024

efiacor Aug 21, 2024

vjayaramrh Aug 21, 2024

efiacor Aug 21, 2024

vjayaramrh Aug 21, 2024

vjayaramrh Aug 21, 2024 •

edited

Loading

radoslawc commented Aug 22, 2024

nephio-prow bot commented Aug 22, 2024

arora-sagar commented Aug 22, 2024

adds prow job to install nephio components on kubeadm cluster #297

adds prow job to install nephio components on kubeadm cluster #297

Conversation

vjayaramrh commented Aug 19, 2024 • edited Loading

vjayaramrh commented Aug 19, 2024

vjayaramrh commented Aug 19, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

arora-sagar commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024 • edited Loading

vjayaramrh commented Aug 20, 2024

nephio-prow bot commented Aug 20, 2024

vjayaramrh commented Aug 20, 2024

vjayaramrh commented Aug 21, 2024

nephio-prow bot commented Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

vjayaramrh Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vjayaramrh Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

radoslawc commented Aug 22, 2024

nephio-prow bot commented Aug 22, 2024

arora-sagar commented Aug 22, 2024

vjayaramrh commented Aug 19, 2024 •

edited

Loading

vjayaramrh commented Aug 20, 2024 •

edited

Loading

nephio-prow bot commented Aug 21, 2024 •

edited

Loading

vjayaramrh Aug 21, 2024 •

edited

Loading

vjayaramrh Aug 21, 2024 •

edited

Loading