Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev release #98

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix dev release #98

merged 2 commits into from
Aug 28, 2024

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented Aug 27, 2024

Update dev build gh acrion to only trigger when merged to main.
Fix e2e gh actions to trigger when deployments dir is changed

@nephio-prow nephio-prow bot requested review from s3wong and tliron August 27, 2024 16:52
@nephio-prow nephio-prow bot added the approved label Aug 27, 2024
Copy link

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes seem straight forward, looks good to me

@Catalin-Stratulat-Ericsson
Copy link
Contributor

/approve

@kispaljr
Copy link
Collaborator

it also looks good to me

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor efiacor merged commit d26d63a into nephio-project:main Aug 28, 2024
4 checks passed
@efiacor efiacor deleted the fix_dev_release branch November 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants