Porchctl command fixes: #81
Conversation
- repo get: Output namespace column when -A/--all flag specified. - repo reg: Use kubeconfig context namespace if -n/--namespace flag not provided. - repo unreg: Use kubeconfig context namespace if -n/--namespace flag not provided.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dimitar-axyomcore The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
Hi @dimitar-axyomcore. Thanks for your PR. I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I am currently working on signing the Corporate CLA |
|
/ok-to-test |
|
At this point I am not sure if the corporate Easy CLA will be signed. Please feel free to assign this issue to someone else. |
|
Hi @efiacor , I made one more effort to sign the corporate CLA. Please give me a few more days and hopefully I could start working on the PR next week. |
it looks like my company is not ready for contributing to Open Source projects, yet. Just to give some context, Axyom.Core was spun off Casa Systems last May and our current priorities don't have room for this task. We have two options. Either I re-open the initial PR opened under my personal GitHub account or you guys complete it. I know the PR has been opened for quite some time now. In any case, thanks for waiting on my response. |
I am not with AxyomCore any more. If possible I'd love to continue working on this issue as an individual contributor. |
Hi @dgeorgievski , You're very welcome. Please visit this link to see how to register as an individual contributor for Nephio: |
Great, and thank you. I've just signed the EasyCLA agreement. |
|
I think you need to need to link the email you submitted the PR on to a Github account, see the message above "The email address for the commit (0f4dcc1) is not linked to the GitHub account, preventing the EasyCLA check." |
|
My apologies. I forgot about the email address. May I suggest re-opening this PR #80, and closing this one? PR #80 was my original submission before we tried to explore the corporage agrement and engage my former employer. Both PRs are identical.
|
|
@dgeorgievski I have just reopened PR #80 |
|
This is a duplicate of #80, which has now been merged |
Fixes for porchctl repo commands described in nephio-project/nephio#755 issue.
-A/--allflag specified.-n/--namespaceflag not provided.-n/--namespaceflag not provided.I've resubmitted this PR under new GH account to be able to sign the corporate CDL.
I would need guidance on how to approach tests for the commands. I've noticed the
repo regcommand uses a fake porch server to handle the tests cases. Should I follow suit for commands affected by this PR?