Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cabundle tls support for git repo comms #58

Merged
merged 7 commits into from
May 31, 2024

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented May 27, 2024

This addresses nephio-project/nephio#488

@efiacor efiacor requested a review from kispaljr May 29, 2024 07:27
@kushnaidu
Copy link
Contributor

/approve

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach and the implementation look fine to me.

@kispaljr
Copy link
Collaborator

Went through the code without testing it.
My only (honest) question is: why are some methods are "unimplemented" (implemented by panic("unimplemented"))? Is it by design that it should panic? If yes, should we change the string from "unimplemented" to something more descriptive?

@efiacor
Copy link
Collaborator Author

efiacor commented May 30, 2024

Went through the code without testing it. My only (honest) question is: why are some methods are "unimplemented" (implemented by panic("unimplemented"))? Is it by design that it should panic? If yes, should we change the string from "unimplemented" to something more descriptive?

So, with a view to keep it somewhat in the same "space" as the existing secret/credential resolver , just extended the Credential Interface.
Unfortunately I cannot use the ToAuthmethod to retrieve the cabundle secret so I added a ToString function. This then forces the impl of that function.
It's not an ideal solution and is somewhat a quick fix for now. We should look to impl a proper solution around extending the Repo CR to add auth/tls.

@kispaljr
Copy link
Collaborator

understood, thx for the clarification.

/lgtm

@nephio-prow nephio-prow bot removed the lgtm label May 30, 2024
@liamfallon
Copy link
Member

/retest

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, kushnaidu, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label May 31, 2024
@nephio-prow nephio-prow bot merged commit 463f777 into nephio-project:main May 31, 2024
5 checks passed
@efiacor efiacor deleted the add_git_tls branch June 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants