Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod templating for function runner #54

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

nagygergo
Copy link
Contributor

Intended to fix nephio-project/nephio#571 See documentation inlined.

Copy link
Contributor

nephio-prow bot commented May 17, 2024

Hi @nagygergo. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liamfallon
Copy link
Member

/ok-to-test

Copy link
Collaborator

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Outdated Show resolved Hide resolved
func/internal/podevaluator.go Show resolved Hide resolved
@liamfallon
Copy link
Member

/retest

@liamfallon
Copy link
Member

@nagygergo end to end tests are failing.

@nagygergo nagygergo closed this May 24, 2024
@nagygergo nagygergo reopened this May 24, 2024
@efiacor
Copy link
Collaborator

efiacor commented May 30, 2024

/retest

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon, nagygergo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 6, 2024
@nephio-prow nephio-prow bot merged commit bf9252a into nephio-project:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porch function runner pod evaluator should allow for pod templating
3 participants