Remove FleetSync controller

[efiacor]

FleetSync was brought over from Kpt and is google specific.
These CRDs and controller are no longer needed or used.

[nephio-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [efiacor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liamfallon]

Just formatting in this file.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

Only cleanup here.

[liamfallon]

@efiacor it would be good to keep formatting/cleanup/whitespace changes in separate PRs to those changing functionality. In this PR, the following files have only formatting changes:
pkg/cmd/server/start.go
pkg/git/git.go
pkg/git/primitives_test.go
pkg/registry/porch/functions.go
pkg/registry/porch/package.go
pkg/registry/porch/packagecommon.go
pkg/registry/porch/packagerevision.go
pkg/registry/porch/packagerevisionresources.go
pkg/registry/porch/packagerevisions_approval.go
pkg/repository/util.go
test/e2e/cli/cluster.go
test/e2e/e2e_test.go
test/e2e/e2e_test_utils.go

So apart from these two files:
controllers/go.mod
controllers/go.sum

This PR boils down to:

Remove Fleetsync CRDs:
controllers/config/crd/bases/config.porch.kpt.dev_fleetmembershipbindings.yaml
controllers/config/crd/bases/config.porch.kpt.dev_fleetmemberships.yaml
controllers/config/crd/bases/config.porch.kpt.dev_fleetscopes.yaml
controllers/config/crd/bases/config.porch.kpt.dev_fleetsyncs.yaml

Remove the Fleetsync controller:
controllers/fleetsyncs

Changes to:
Makefile
controllers/main.go

@tliron please check

[efiacor]

@efiacor it would be good to keep formatting/cleanup/whitespace changes in separate PRs to those changing functionality. In this PR, the following files have only formatting changes: pkg/cmd/server/start.go pkg/git/git.go pkg/git/primitives_test.go pkg/registry/porch/functions.go pkg/registry/porch/package.go pkg/registry/porch/packagecommon.go pkg/registry/porch/packagerevision.go pkg/registry/porch/packagerevisionresources.go pkg/registry/porch/packagerevisions_approval.go pkg/repository/util.go test/e2e/cli/cluster.go test/e2e/e2e_test.go test/e2e/e2e_test_utils.go

So apart from these two files: controllers/go.mod controllers/go.sum

This PR boils down to:

Remove Fleetsync CRDs: controllers/config/crd/bases/config.porch.kpt.dev_fleetmembershipbindings.yaml controllers/config/crd/bases/config.porch.kpt.dev_fleetmemberships.yaml controllers/config/crd/bases/config.porch.kpt.dev_fleetscopes.yaml controllers/config/crd/bases/config.porch.kpt.dev_fleetsyncs.yaml

Remove the Fleetsync controller: controllers/fleetsyncs

Changes to: Makefile controllers/main.go

@tliron please check

Agreed. I mistakenly ran gofmt and forgot to revert.

[johnbelamaric]

This is used in the GCP install and I brought it over for that purpose. @tliron can we move this to a GCP controller instead of removing it?

[efiacor]

nephio-project/nephio#465

[efiacor]

This is used in the GCP install and I brought it over for that purpose. @tliron can we move this to a GCP controller instead of removing it?

Hi @johnbelamaric , chatting with Tal we agreed the moving this to it's own repo would add unnecessary overhead.
The GCP install is using the kpt v31 of the controllers - https://github.com/nephio-project/catalog/blob/main/distros/gcp/nephio-mgmt/porch/9-controllers.yaml#L46

Do we need to continue to support the GCP install in nephio?