Refactor of the Developer Environment setup script #43
Conversation
- script made idempotent (you can rerun it without any cleanup) - script exits on error - the following values are turned into a parameter: name of kind cluster, name of git repo, Gitea external IP - Gitea install package is manipulated by KRM functions instead of sed
…ort that is forwarded to the host in the kind cluster's config
… readiness (the later fails if the pod hasn't been created yet)
| curl -s https://raw.githubusercontent.com/nephio-project/porch/main/docs/tutorials/starting-with-porch/kind_management_cluster.yaml | \ | ||
| kind create cluster --config=- | ||
|
|
||
| curl -s https://raw.githubusercontent.com/nephio-project/porch/main/docs/tutorials/starting-with-porch/kind_edge1_cluster.yaml | \ |
There was a problem hiding this comment.
Not a major issue but I think the orig guide, which this is an extension of is using the egde1 cluster.
https://github.com/nephio-project/porch/tree/main/docs/tutorials/starting-with-porch#deploying-a-blueprint-onto-a-workload-cluster
There was a problem hiding this comment.
Yes, I was a bit uncertain regarding removing edge1. My rationale was that the "Starting with Porch" tutorial is more like a "User's Guide", while this script belongs to the "Setup the Developer Environment" guide. And I think edge1 is not needed to develop and test porch, it belongs more to ConfigSync.
All-in-all I can add back edge1 if we think there is need for it during development.
There was a problem hiding this comment.
Maybe adding back the edge1 git repo only, but not the kind cluster would also make sense.
There was a problem hiding this comment.
Ye I guess either way the README guides will need to be updated a bit.
May be best to get @liamfallon direction on it when he is back on 13/05
There was a problem hiding this comment.
I am planning to update the text of the tutorial as part of #44
There was a problem hiding this comment.
This looks great! Thanks for cleaning up the setup @kispaljr
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Includes the following changes: