Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformatting TestWatchCertificates #158

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Reformatting TestWatchCertificates #158

merged 2 commits into from
Dec 12, 2024

Conversation

Catalin-Stratulat-Ericsson
Copy link
Contributor

This PR attempts to break up the TestWatchCertificates test into each individual test case with more time allowance for each test alongside a slightly better approach.
This does not fix the fundamental issue of the testing using logs but it should hopefully lead to far less flakiness in this test

@nephio-prow nephio-prow bot requested review from s3wong and tliron December 11, 2024 16:51
@Catalin-Stratulat-Ericsson Catalin-Stratulat-Ericsson requested review from liamfallon and efiacor and removed request for s3wong and tliron December 11, 2024 16:51
@efiacor
Copy link
Collaborator

efiacor commented Dec 12, 2024

/approve

@nephio-prow nephio-prow bot added the approved label Dec 12, 2024
@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

12 similar comments
@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@Catalin-Stratulat-Ericsson
Copy link
Contributor Author

/test presubmit-nephio-go-test

@efiacor
Copy link
Collaborator

efiacor commented Dec 12, 2024

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 12, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit c017ed2 into nephio-project:main Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon Awaiting requested review from liamfallon

@efiacor efiacor Awaiting requested review from efiacor

Assignees

@efiacor efiacor

@Catalin-Stratulat-Ericsson Catalin-Stratulat-Ericsson

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catalin-Stratulat-Ericsson @efiacor