Nephio network editor. Configurable editor fixes and performance enhancement. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e editor components. Created first performance tests which showcase the problem of unneeded re-renders.
…avoid prop-drilling.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kamilmadejek, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces multiple improvements to the configurable editor component which make it feasible for implementation of editors for complex, multi-level Kubernetes resources.
Also, several suites of integration tests have been created for the configurable editor.
The aforementioned improvements to the configurable editor have been utilized in the creation of editor for Nephio Network resource, which is a example of a complex object with several levels of nested data.
The implementation of Network editor also showcases limitation of the current editor UI. Its ineffective use of available space and handling of nested data provides poor legibility and user experience, especially when complex resources are concerned. Next PRs will be focused on the redesign effort.
Testing (on
uitestsenvironment, credentials available per request):Networkparametric editor