-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editors for Nephio-specific resources (1st batch). #58
Editors for Nephio-specific resources (1st batch). #58
Conversation
This time I'm publishing the PR from my private account (with linked Samsung email), so it seems I have to go through CLA authorization again. Hopefully it will be cleared soon. |
/easycla |
Note to the reviewers and approvers: please ignore result of GitHub action: 'Generate Dependabot Configuration / run_python_script (pull_request)' it has no impact and status was added by error. |
I created this PR in an unfortunate moment, when it went unnoticed, buried beneath the avalanche of auto-generated Dependabot PRs 🙂 Now that we have this matter sorted out, I would be grateful if you could take a look at it. |
Hi @kamilmadejek , this looks interesting. |
Hi @efiacor, sure, I'll try to prepare this for Monday. |
Hi @efiacor, I managed to prepare a Web UI deployment with these changes. I will share access details using a private channel. The work done in this PR is quite rudimentary - it adds three relatively simple editors for Nephio-specific resources. These new editors are implemented in a similar way to already existing editors, thus they share their drawbacks (code duplication, some pre-existing bugs and quirks etc.). This PR serves mostly as my introduction to the topic. I am currently prototyping a new approach for implementing editors, which aims to make their development more streamlined and the code more maintainable. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: efiacor, kamilmadejek, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds three new editor UIs for resource types which are specific to Nephio:
infra.nephio.org/v1alpha1/WorkloadCluster
infra.nephio.org/v1alpha1/Token
req.nephio.org/v1alpha1/Capacity
At this moment, the Web UI project does not support GUI editor functionality for any of Nephio-specific resource types. This PR is the beginning of a bigger effort which aims to close this gap and provide graphical editors for all relevant Nephio resources.
This PR follows previously established practices and editor creation conventions, which involve significant code repetition. Following PRs will aim to rework existing and new editors in a way which promotes code reuse and adheres to DRY principles.
Example of
WorkloadCluster
editor.Additional tweaks and fixes include:
LOCAL_PROXY
configuration mode, which makes it possible for WebUI developers to connect application to a Kubernetes proxy. SSH port forwarding can be used to easily connect to a remote cluster.useSetStateAndCall
React hook which aims to limit undesirable usage ofuseEffect
hook for reacting to state changes.