Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auth app to create PR #23

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

radoslawc
Copy link

Instead of using fixed token this will make use of GitHub App to generate ephemeral token for each run to keep it safer.

@nephio-prow nephio-prow bot requested review from efiacor and tliron August 1, 2024 10:03
@vjayaramrh
Copy link

/lgtm

@efiacor
Copy link

efiacor commented Aug 15, 2024

/approve

Copy link

nephio-prow bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 15, 2024
@radoslawc radoslawc merged commit 3c22686 into nephio-project:main Aug 15, 2024
9 checks passed
@radoslawc radoslawc deleted the use_auth_app branch August 15, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants