Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated free5gc amf package to align with r2 #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated free5gc amf package to align with r2 #49

wants to merge 1 commit into from

Conversation

henderiw
Copy link
Contributor

No description provided.

@nephio-prow nephio-prow bot requested review from s3wong and tliron January 11, 2024 02:49
@henderiw henderiw changed the title updated free5gc amt package to align with r2 updated free5gc amf package to align with r2 Jan 11, 2024
@liamfallon
Copy link
Member

/assign @lapentad

@lapentad
Copy link
Contributor

@henderiw I can update SMF and UPF with the NFdeployment changes and e2e test them

@arora-sagar
Copy link
Contributor

@lapentad I just realized that the operator package is not updated with the latest NFDeployment changes so the operator has to be updated too. Also once the packages are updated we can move them to catalog/workloads/free5gc or we can move them now and update them there.

This was referenced Jan 12, 2024
Merged
Merged
nephio-prow bot pushed a commit that referenced this pull request Jan 12, 2024
@lapentad
Updated free5gc UPF package to align with r2 (#50)
80753bf 
Updating packages to move into
[catalog](https://github.com/nephio-project/catalog/tree/main/workloads/free5gc)

Based on
[49](#49)
@lapentad
Copy link
Contributor

/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lapentad
Once this PR has been reviewed and has the lgtm label, please ask for approval from henderiw by writing /assign @henderiw in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nephio-prow bot pushed a commit that referenced this pull request Jan 12, 2024
@lapentad
Updated free5gc smf package to align with r2 (#51)
549b9c4 
Updating packages to move into
[catalog](https://github.com/nephio-project/catalog/tree/main/workloads/free5gc)

Based on
[49](#49)
electrocucaracha
electrocucaracha reviewed Jan 16, 2024
View reviewed changes
pkg-example-amf-bp/amfdeployment.yaml
metadata:
name: amf-example
namespace: amf-example
spec:
provider: amf.free5gc.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that your editor has added a Line Ending, this could be happened if you are using a Windows editor. Maybe using config in Notepad++ can avoid it.

@tliron
Copy link
Contributor

tliron commented Jan 24, 2024

Is it OK to delete this PR? The catalog repo is the new location, this repo has been deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha left review comments

@s3wong s3wong Awaiting requested review from s3wong

@tliron tliron Awaiting requested review from tliron

Assignees

@lapentad lapentad

Labels
None yet
Projects
Nephio R2
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@henderiw @liamfallon @lapentad @arora-sagar @tliron @electrocucaracha