rust-analyzer: Fix is_library #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremija
force-pushed
the
jeremija/fix-rust-analyzer-root-dir-check
branch
from
e8b2087 to
4d315c5
Compare
I'm not that well versed in Lua, but the previous check if fname:sub(1, #item) == item didn't really work as expected and I was still experiencing high CPU usage when using the `go to definition` functionality. After adding some print statements for debugging, I noticed that only a few strings were removed from the base dir and thus the comparison was failing. Perhaps it might work differently in other operating systems, but my Linux machine it did not work correctly. I replaced this check with `util.path.is_descendant` which now works correctly, as well as added another path to check when git repositories are used as cargo dependencies.
jeremija
force-pushed
the
jeremija/fix-rust-analyzer-root-dir-check
branch
from
4d315c5 to
5efd0a6
Compare
|
LGTM thanks :) |
|
Cool, thanks for the blazing fast review and merge! |
|
Actually, I got confused, the |
for some special cases, the directory cannot be judged by truncation maybe 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not that well versed in Lua, but the previous check
if fname:sub(1, #item) == item
didn't really work as expected and I was still experiencing high CPU
usage when using the
go to definitionfunctionality. After adding someprint statements for debugging, I noticed that only a few chars were
removed from the base dir and thus the comparison was failing. Perhaps
it might work differently in other operating systems, but my Linux
machine it did not work correctly.
I replaced this check with
util.path.is_descendantwhich now workscorrectly, as well as added another path to check when git repositories
are used as cargo dependencies.