feat(texlab): add cancelBuild #2977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithammer
reviewed
Jan 19, 2024
| if err then | ||
| error(tostring(err)) | ||
| end | ||
| print 'Build cancelled' |
There was a problem hiding this comment.
Use vim.notify() instead of print.
justinmk
reviewed
Jan 29, 2024
| local function buf_cancel_build() | ||
| local texlab_client = util.get_active_client_by_name(0, 'texlab') | ||
| if texlab_client then | ||
| texlab_client.request('workspace/executeCommand', { command = 'texlab.cancelBuild' }, function(err) |
There was a problem hiding this comment.
isn't workspace/executeCommand part of the LSP spec? should this use :help vim.lsp.commands ?
There was a problem hiding this comment.
Thanks for the reply and the suggestion. Reading the docs on the vim.lsp.commands I too think it should be used here. However, the docs were not very helpful on how to implement it, even looking at the source code in neovim i could not get it to work. Moreover, i found another implementation with the request in the following part from the es-lint config. I could really use some help regarding how to proceed, thanks in advance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command for the new workspace command of texlab for canceling the build, including the onSave ones. I think it is pretty useful. Thanks for your effort and help