Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dcmls config #2969

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

RobertBrunhage
Copy link
Contributor

No description provided.

@RobertBrunhage RobertBrunhage changed the title chore: update dcm config chore: update dcmls config Jan 14, 2024
@glepnir
Copy link
Member

glepnir commented Jan 14, 2024

It's better test in your local to make sure all it can works . and add more spec in default description about why add yaml filetype .

@RobertBrunhage
Copy link
Contributor Author

RobertBrunhage commented Jan 14, 2024

It's better test in your local to make sure all it can works.

Got feedback from creator of DCM that -- was missing. This was not visible locally.

and add more spec in default description about why add yaml filetype

It can analyze yaml files as well for lint rules, which I didn't know about.

@glepnir
Copy link
Member

glepnir commented Jan 14, 2024

emm I think it's better disable yaml as default.. because yaml has their own server ymls.

@RobertBrunhage
Copy link
Contributor Author

emm I think it's better disable yaml as default.. because yaml has their own server ymls.

Got it, will do

@glepnir glepnir merged commit 0372dfb into neovim:master Jan 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants