spyglassmc: Make root_dir unrequired. #2962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default, it is set to pack.mcmeta, and if pack.mcmeta is missing in your directory regardless whether single_file_support is true or false, the spyglass language server will throw an error and wont work. this fixes the problem
|
i will try to fix it |
|
to whoever requested to review - this is not done yet, i havent even started |
glepnir
reviewed
Jan 13, 2024
| @@ -4,7 +4,7 @@ return { | |||
| default_config = { | |||
| cmd = { 'spyglassmc-language-server', '--stdio' }, | |||
| filetypes = { 'mcfunction' }, | |||
| root_dir = util.root_pattern 'pack.mcmeta', | |||
| root_dir = function() return vim.loop.cwd() end, | |||
There was a problem hiding this comment.
it would be better to extend the default patterns to be more inclusive, maybe add a .git .svn or another specific to spyglass root directory marker, cwd() is a bad idea here.
justinmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default, root_dir set to pack.mcmeta, and if pack.mcmeta is missing in your directory regardless whether single_file_support is true or false, the spyglass language server will throw an error and wont work. this pr fixes the problem.
this could be a wrong approach tho, ill try to find other ways to fix this later too.