fix(zls): use workspace zls.json if available #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
reviewed
Dec 21, 2023
justinmk
reviewed
Oct 1, 2024
justinmk
reviewed
Oct 1, 2024
|
needs a rebase, the |
lawrence-laz
force-pushed
the
fix-zls-use-workspace-configuration
branch
from
9bd03c9 to
cff9e24
Compare
Language server config is read from `zls.json`. By default common global and user config directories are searched. However, this omits per-project configuration, which can be available in the workspace dir. We already look for `zls.json` to determine root dir, but we don't use it when starting the language server. This change appends `cmd` with `--config-path "zls.json"`, which uses the file when it's available and fall-backs to default logic when file is not available.
lawrence-laz
force-pushed
the
fix-zls-use-workspace-configuration
branch
from
cff9e24 to
5ac8aa1
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language server config is read from
zls.json. By default common global and user config directories are searched. However, this omits per-project configuration, which can be available in the workspace dir.We already look for
zls.jsonto determine root dir, but we don't use it when starting the language server.This change appends
cmdwith--config-path "zls.json", which uses the file when it's available and fall-backs to default logic when file is not available.