feat: Add circom-lsp #2848
Merged
feat: Add circom-lsp #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
reviewed
Oct 2, 2023
| filetypes = { 'circom' }, | ||
| root_dir = function() | ||
| local root = util.root_pattern(root_files)(vim.fn.expand '%:p') | ||
| return root or vim.api.nvim_buf_get_name(0) |
There was a problem hiding this comment.
i don't think use current bufname is useful if you want root is current dir just single_file_support = true
There was a problem hiding this comment.
Yes I agree
Simplify the configuration by setting single_file_support to true. This approach is more straightforward, as you don't need to specify root_files or create a custom root_dir function.
There was a problem hiding this comment.
Set single_file_support to true for improved simplicity.
|
Hey @glepnir Can you please review the PR whenever you are free? |
glepnir
reviewed
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the feature request #2833
Added circom-lsp.lua.
Ran all the linting checks.
Please look into the PR and merge if OK.
Thanks