Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API tests #170

Merged
merged 1 commit into from
May 13, 2024
Merged

Improve API tests #170

merged 1 commit into from
May 13, 2024

Conversation

garyburd
Copy link
Contributor

  • Get expected runtime paths by evaluating a VimL expression.
  • Use equality operator to compare strings instead of reflect.DeepEqual.
  • Fix typo in event name.

@garyburd
Improve API tests
e83e51b 
- Get expected runtime paths by evaluating a VimL expression.
- Use equality operator to compare strings instead of reflect.DeepEqual.
- Fix typo in event name.
justinmk
justinmk approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@justinmk justinmk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The test failures for "nightly" are unrelated. #171

@justinmk justinmk merged commit 9b44fee into neovim:main May 13, 2024
10 of 19 checks passed
@garyburd garyburd deleted the errors branch May 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk approved these changes

Assignees
No one assigned
Labels
area/nvim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyburd @justinmk