Task/optimise test suite #5341
Draft
Task/optimise test suite #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bwaidelich
reviewed
Nov 4, 2024
|
|
||
| class ContentRepositoryInternalsAccessor implements ContentRepositoryServiceFactoryInterface | ||
| { | ||
| public ContentRepositoryServiceFactoryDependencies $spiedInternals; |
There was a problem hiding this comment.
Suggestion: expose (just) the required dependencies as explicit public readonly fields
| @@ -57,6 +57,7 @@ public function resetContentRepositoryComponents(BeforeScenarioScope $scope): vo | |||
| } | |||
|
|
|||
| protected function getContentRepositoryService( | |||
| ContentRepositoryId $contentRepositoryId, | |||
There was a problem hiding this comment.
Just wondering: why do we have to change the signature? Can't we just refer to currentContentRepository?
bwaidelich
reviewed
Nov 6, 2024
| @@ -133,7 +133,7 @@ public function build(ContentRepositoryServiceFactoryDependencies $serviceFactor | |||
| }; | |||
| } | |||
| }; | |||
| $this->getContentRepositoryService($propertyConverterAccess); | |||
| $this->getContentRepositoryService($this->currentContentRepository->id, $propertyConverterAccess); | |||
There was a problem hiding this comment.
Isn't that exactly one of the hacks we should be able to replace now?
$propertyConverter = $this->getContentRepositoryServiceFactoryDependencies($this->currentContentRepository->id)->propertyConverter;
bwaidelich
reviewed
Nov 6, 2024
There was a problem hiding this comment.
@mhsdesign a short explanation in the PR and this is good to go, no?
|
@mhsdesign this PR would help me. Should I take over or can you take care of the remaining tweaks? |
|
ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions