TASK: Remove explicit deprecated command blocking #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This change was partially ported from neos#4988 Following things have been adjusted: - Removal of the step: The graph projection is fully up to date - remove lastCommandOrEventResult - Removal of the step: The documenturipath projection is up to date - Use injected Connection in tests instead of DoctrineDbalClient (this will be fully refactored in neos#4988)
mhsdesign
force-pushed
the
task/removeExplicitDeprecatedBlocking
branch
from
aea4ff0
to
bba472b
Compare
bwaidelich
approved these changes
May 17, 2024
This is super unrelated :/ |
yes. I agree - and it was somehow unrelated in my large PR, too.. |
|
yes thats the only part that bums me as well but @bwaidelich started it in his pr and this is a partial fyi. I did a review myself and can confirm that only the stuff that needed to has been removed from the .feature files. |
|
|
mhsdesign
force-pushed
the
task/removeExplicitDeprecatedBlocking
branch
from
836781b
to
0df9079
Compare
|
Missing import and no phpstan coverage :D |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was partially ported from #4988
Following things have been adjusted:
CommandResult::blockin phpUpgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions