Fix order of nextTick processing to match nodejs #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodejs processes callbacks added by process.nextTick in a queue (=> LIFO order). Lowjs uses a stack (=>FIFO order).
This causes issues, e.g in readable-streams, where I had 'readable' events after the 'end' event, which in turn caused a deadlock in code unprepared for this event order.
Demo code to check lowjs and nodejs behavior:
This PR fixes the order used by lowjs by inserting new callbacks at the bottom of the stack. While this is suboptimal for a large number of callbacks, in real world code the number of callbacks usually is not that large, so the O(n²) behaviour of the insertion method should not matter.