Run promote-images in parallel to test-images on branches other than main/release #10267
+32
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, that submodule rewind was accidental, sorry :| |
jcgruenhage
force-pushed
the
jcgruenhage/promote-images-while-test-images
branch
3 times, most recently
from
ae83fab to
7d839ac
Compare
jcgruenhage
commented
Jan 3, 2025
jcgruenhage
force-pushed
the
jcgruenhage/promote-images-while-test-images
branch
4 times, most recently
from
d16ba65 to
b2497b7
Compare
jcgruenhage
commented
Jan 3, 2025
| @@ -33,7 +33,7 @@ jobs: | |||
| # SC2086 - Double quote to prevent globbing and word splitting. - https://www.shellcheck.net/wiki/SC2086 | |||
| SHELLCHECK_OPTS: --exclude=SC2046,SC2086 | |||
| with: | |||
| fail_on_error: true | |||
| fail_level: error | |||
There was a problem hiding this comment.
reviewdog/action-actionlint@9543997, fail_on_error is deprecated. Should I move this into a separate PR?
7227 tests run: 6873 passed, 0 failed, 354 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
03dd0b2 at 2025-01-03T18:26:01.692Z :recycle: |
jcgruenhage
force-pushed
the
jcgruenhage/promote-images-while-test-images
branch
from
b2497b7 to
03dd0b2
Compare
conradludgate
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
trigger-e2e-testswaits half an hour before starting to run. Nearly half of that time can be saved by promoting images before tests on them are complete, so the e2e tests can run in parallel.On
mainandrelease{,-proxy,-compute},promote-imagesupdateslatestand pushes things to prod ecr, so we want to runpromote-imagesonly aftertest-imagesis done, but on other branches, there is no harm in promoting images that aren't tested yet.Summary of changes
To promote images into dev container registries sooner,
promote-imagesis split intopromote-images-devandpromote-images-prod. The former pushes to dev container registries, the latter to prod ones. The latter also waits fortest-images, while the former doesn't. This allows to runtrigger-e2e-testssooner.